Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out Protobuf in our repository #8

Closed
Levi-Lesches opened this issue Jun 23, 2022 · 2 comments
Closed

Sort out Protobuf in our repository #8

Levi-Lesches opened this issue Jun 23, 2022 · 2 comments
Assignees
Labels
area: networking Involves network communications type: enhancement New feature or request

Comments

@Levi-Lesches
Copy link
Member

Levi-Lesches commented Jun 23, 2022

So far, the plan is to have two separate repositories.

  • rover-api: holds the .proto files for all possible rover messages
  • rover-network: holds the C++ and Dart networking libraries, including a wrapper .proto file

We need to

  • include the rover-api proto files in our implementation, and store the generated code under lib/src/data/messages
  • import the rover-network library, which should already include the generated WrapperMessage class.
@Levi-Lesches Levi-Lesches added area: networking Involves network communications area: project Topics related to project management labels Jun 23, 2022
@Levi-Lesches Levi-Lesches changed the title Figure out where protoc belongs in our toolchain Sort out Protobuf in our repository Jun 23, 2022
@Levi-Lesches
Copy link
Member Author

Levi-Lesches commented Jun 23, 2022

Alternatively, we can have one networking repository rover-api that just holds all the .proto files. Then, we can store our Dart-specific networking code in lib/src/services/networking and the generated message classes in lib/src/data/messages. The C++ library can then stay in its own relevant locations. This would simplify our structure since

  1. We won't need to import a repository that's half C++
  2. We anyway need some networking code in our lib/src/services folder, even if we import most of it

@Levi-Lesches
Copy link
Member Author

Being tracked in BinghamtonRover/Protobuf#1

@Levi-Lesches Levi-Lesches added duplicate type: enhancement New feature or request and removed area: project Topics related to project management labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: networking Involves network communications type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants