Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define specific rover commands and their protobuf equivalents #4

Closed
Levi-Lesches opened this issue Jun 10, 2022 · 1 comment
Closed
Assignees
Labels
area: networking Involves network communications

Comments

@Levi-Lesches
Copy link
Member

Levi-Lesches commented Jun 10, 2022

Perhaps this should be under the new Rover API repo instead, but filing here for now.

We need to convert all the possible commands from https://github.com/BinghamtonRover/BurtOS-2/blob/main/src/subsystem/can/constants.hpp to both Dart representations and their Protobuf equivalents.

I don't have much experience with Protobuf yet, but I can see that all these commands will have arguments, so the Dart representation would need to be something like

class RoverMessage {
  final int id;
  final double value;  // or int?
}

and then later, in the networking service, we would have a function

Future<void> send(RoverMessage message) { }

Then of course, we'd need to make the protobuf message files as well.

@Levi-Lesches
Copy link
Member Author

Levi-Lesches commented Jul 21, 2022

Being tracked by BinghamtonRover/Protobuf#1 with a different implementation

@Levi-Lesches Levi-Lesches closed this as not planned Won't fix, can't repro, duplicate, stale Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: networking Involves network communications
Projects
None yet
Development

No branches or pull requests

1 participant