Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenges Bug - OneTime challenge not dissapearing #337

Open
Nergl02 opened this issue Apr 2, 2024 · 11 comments
Open

Challenges Bug - OneTime challenge not dissapearing #337

Nergl02 opened this issue Apr 2, 2024 · 11 comments
Assignees
Labels
Status: Under investigation Investigating the interest and the feasability of the issue.

Comments

@Nergl02
Copy link

Nergl02 commented Apr 2, 2024

Expected behavior

When player completed the challenge it should dissapear rom /ob challenge

Observed/Actual behavior

When player completed the challenge, it doesnt dissapear from /ob challenge

Steps/models to reproduce

no error

BentoBox version

challenges - 1.3.0

Plugin list

image
image

Other

No response

@tastybento
Copy link
Member

Which one? Was it one you made?

If you use the default JSON database, then look in plugins/BentoBox/database/Challenge for the challenge you think should disappear. It will be called something like bskyblock_cobblegenerator.json or whatever name you gave it. Open up the file in an editor. Look for this line:

"removeWhenCompleted": true,

This means it will be removed when done. But if it says

"removeWhenCompleted": false,

then it will not remove when complete.

What does it say?

BTW, this is a setting when you make the challenges.

@Nergl02
Copy link
Author

Nergl02 commented Apr 5, 2024

I looked in plugins/BentoBox/database/Challenge and its empty.

I know, its in the setings, when i make challenges.

I even set it in this:
image

image

@tastybento
Copy link
Member

Can you run /bbox v in the console and paste the output here so I can see what exactly your setup is?

@Nergl02
Copy link
Author

Nergl02 commented Apr 5, 2024

image

@tastybento
Copy link
Member

Thanks. I've replicated this issue.

@tastybento tastybento self-assigned this Apr 5, 2024
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Type: Bug A bug in code. labels Apr 5, 2024
@tastybento
Copy link
Member

tastybento commented Apr 5, 2024

Hmm, I cannot replicate with free challenges. It seems to work for me.

Set up challenge:
Screenshot 2024-04-05 at 1 06 05 PM
Make sure it is not repeatable (repeatable ones will not disappear):
Screenshot 2024-04-05 at 1 06 48 PM
Do the challenge:
Screenshot 2024-04-05 at 1 03 03 PM

Select the free ones:
Screenshot 2024-04-05 at 1 03 27 PM

Complete the challenge:
Screenshot 2024-04-05 at 1 04 20 PM
Free challenge has disappeared:
Screenshot 2024-04-05 at 1 04 35 PM

Is the challenge you set repeatable? If so, and the repeat value is 1, then it won't disappear.

@tastybento tastybento removed the Type: Bug A bug in code. label Apr 5, 2024
@Nergl02
Copy link
Author

Nergl02 commented Apr 6, 2024

no, repeatable is disabled
image

@tastybento
Copy link
Member

I cannot replicate so I think I'll need a copy of your database, or at least the tables for Challenges. They will be in your MariaDB as:

Challenge and ChallengeLevel

You can also just dump the whole database, zip it and drag and drop here. Use this command:

mysqldump -u username -p database_name > data-dump.sql

Source

I'll put it into my MariaDb and try and see what is causing the issue. Be sure to tell me what challenge it is.

@Nergl02
Copy link
Author

Nergl02 commented Apr 6, 2024

hmm, i do not have database added in challenges, is it by this?

@BONNe
Copy link
Member

BONNe commented Apr 6, 2024

Or ./(Admin_cmd) challenges export data
And upload data file from plugins/bentobox/addons/challenges folder

@Nergl02
Copy link
Author

Nergl02 commented Apr 6, 2024

here it is
exportbug.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Under investigation Investigating the interest and the feasability of the issue.
Projects
None yet
Development

No branches or pull requests

3 participants