Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Armor Protection Against Acid Rain/Damage via Permissions in AcidIsland #157

Closed
2 tasks done
tylerking opened this issue Jul 21, 2024 · 0 comments · Fixed by #158
Closed
2 tasks done
Assignees
Labels
done This has been done

Comments

@tylerking
Copy link

tylerking commented Jul 21, 2024

Is your feature request related to a problem?

Yes, the current implementation for protecting players from acid damage in AcidIsland is not flexible enough. It only allows protection through general settings like disabling damage for operators or requiring any helmet or full armor set. This limitation prevents the use of custom sets of armor, such as a Hazmat Suit created in plugins like Oraxen, which could enhance gameplay by adding more variety and customization options.

In our Minecraft server, we aim to create a more immersive and engaging experience by introducing custom items and armor sets. For example, we have developed a Hazmat Suit using the Oraxen plugin that fits well within the post-apocalyptic theme of our world. However, the current protection settings in AcidIsland do not allow us to specify this custom armor set as a valid protection against acid damage. By enabling this feature, we can provide players with unique items that have specific gameplay benefits, thus enhancing the overall player experience and adding depth to the game mechanics.

Describe the solution you'd like.

I would like to see an additional feature in AcidIsland that allows server administrators to specify a permission node or directly define specific custom armor sets that provide protection against acid damage. The simplest implementation could involve adding a permission, such as acidisland.protection.acid and acidisland.protection.rain, which can be assigned to players who are wearing designated custom armor sets. Adding a percentage option on each would also be nice so you could prevent a specific amount of damage done using a permission like acidisland.protection.acid.50/acidisland.protection.rain.50 which would do only 50% damage. This approach would offer maximum flexibility, allowing us to create and manage multiple custom armors with protection capabilities without modifying the plugin’s core code.

Describe alternatives you've considered.

Modifying Core Plugin Code: Customizing the AcidIsland plugin code to recognize our specific armor sets, but this is not sustainable as it complicates future updates and maintenance.

There is acidisland.mod.noburn but that doesn't specify just protecting from rain and I believe added player specific permissions for acid damage along with acid raid would be better.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response

@tylerking tylerking changed the title Add Custom Armor Protection Against Acid Damage via Permissions in AcidIsland Add Custom Armor Protection Against Acid Rain/Damage via Permissions in AcidIsland Jul 21, 2024
@tastybento tastybento self-assigned this Jul 22, 2024
@tastybento tastybento linked a pull request Jul 22, 2024 that will close this issue
@tastybento tastybento added done This has been done and removed under investigation labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done This has been done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants