Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new placeholder that will list each block contained in a phase. #385

Closed
2 tasks done
spookymgmt opened this issue Apr 16, 2024 · 7 comments · Fixed by #386
Closed
2 tasks done

A new placeholder that will list each block contained in a phase. #385

spookymgmt opened this issue Apr 16, 2024 · 7 comments · Fixed by #386
Assignees
Labels
done task has been completed

Comments

@spookymgmt
Copy link

Is your feature request related to a problem?

No

Describe the solution you'd like.

Something like [block-phase-list], that is used in the /ob phases menu.

When used, it'll list every block contained in each phase, inside the lore of that phase in /ob phases.

Example lore when using placeholder

&7- &eCobblestone
&7- &eStone
&7- &eDirt

Describe alternatives you've considered.

Cant think of any

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

Ill throw a $30 bounty on this feature request.

@Mithranduil
Copy link

just write it self, so its not to spammy with big phases:
https://prnt.sc/-v8B1xlK3mte

@tastybento tastybento self-assigned this Apr 17, 2024
@tastybento tastybento added the Status: In progress Working on the issue. label Apr 17, 2024
@tastybento tastybento linked a pull request Apr 17, 2024 that will close this issue
tastybento added a commit that referenced this issue Apr 17, 2024
@tastybento tastybento added done task has been completed and removed Status: In progress Working on the issue. labels Apr 17, 2024
@tastybento
Copy link
Member

Please see #386 for details on how this works and the options. It should be available for testing on ci.bentobox.world after it compiles.

@BONNe
Copy link
Member

BONNe commented Apr 17, 2024

tasty, not that kinda of placeholder :D

Placeholder in locale and panels

@tastybento tastybento reopened this Apr 17, 2024
@tastybento
Copy link
Member

Aha, okay. It would need this still though right? @spookymgmt Can you clarify?

@tastybento tastybento added the under investigation this is being checked out label Apr 17, 2024
@spookymgmt
Copy link
Author

spookymgmt commented Apr 17, 2024

Aha, okay. It would need this still though right? @spookymgmt Can you clarify?

Yes the currently added thing, thank you by the way, that is very helpful. I'll be using that.

Also though as BONNe said, if possible could we also get one for this spot? This way, players can type /is phases, and hover over every available phase so they can see what each phase offers block wise?

gui:
titles:
phases: '&6&lONEBLOCK &8✦ &8Phases'
buttons:
previous:
name: '&f&l Previous Page'
description: '&7 Switch to [number] page'
next:
name: '&f&l Next Page'
description: '&7 Switch to [number] page'
phase:
name: '&f&l [phase]'
description: "[starting-block]\n&7 \n[biome]"
starting-block: '&7Unlocked after &e%aoneblock_my_island_count%/[number] &7blocks
mined.'
biome: '&7 Biome: &e [biome]'
bank: '&7 Requires &e $[number] &7 in bank account.'
economy: '&7 Requires &e $[number] &7 in player account.'
level: '&7 Requires &e [number] &7 island level.'
permission: '&7 Requires &e[permission]&7 permission.'

Also, I've went ahead and set the $30, thanks for looking into this.

tastybento added a commit that referenced this issue Apr 18, 2024
tastybento added a commit that referenced this issue Apr 18, 2024
@tastybento tastybento removed the under investigation this is being checked out label Apr 18, 2024
@tastybento
Copy link
Member

tastybento commented Apr 18, 2024

Okay, done (again!)

There are new locale strings.

[blocks] is in the description.

      phase:
        name: '&f&l [phase]'
        description: |-
          [starting-block]
          [biome]
          [bank]
          [economy]
          [level]
          [permission]
          [blocks]

Then this part defines what you'll get in [blocks]:

        # Replaces text with [blocks]
        blocks-prefix: '&7 Blocks in phase - '
        blocks: '&e [name], '
        wrap-at: '50'

Hopefully, this is self explanatory.

I tried the long list but this is what it looked like originally:
Screenshot 2024-04-17 at 7 52 38 PM

So, I made the list one line with a wrap done at 50 chars, so now it looks like this:

Screenshot 2024-04-17 at 9 13 03 PM

Which is still a lot of text, but at least it fits. You can adjust the wrap and how each block type is formatted.

To try it out download from ci.bentobox.world. You will need to delete the Askyblock locale file to get the new strings. plugins/BentoBox/locales/AOneBlock

@tastybento
Copy link
Member

Also, thanks for donation. If you are on Discord share your tag and I'll give you the donor rank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done task has been completed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants