Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to decide whether or not match_params are auto-generated #138

Open
bb-jeriel opened this issue Jun 10, 2021 · 2 comments
Open

Flag to decide whether or not match_params are auto-generated #138

bb-jeriel opened this issue Jun 10, 2021 · 2 comments
Labels
enhancement New feature or request more information required
Milestone
Release 1.2.1

Comments

@bb-jeriel
Copy link

Background

  • Currently, it appears that match params are generated based off the match_params_template.rb file. If we do not wish to use some of these parameters and choose to remove them, they regenerate automatically anytime the Variants command is run.

Solution

  • Provide a flag that determines whether some of these params should be automatically added
@bb-jeriel bb-jeriel added the enhancement New feature or request label Jun 10, 2021
@arthurpalves
Copy link
Member

@bb-jeriel can you give specific examples of parameters you don't wish to have in match_params.rb?

@arthurpalves arthurpalves added this to the Release 1.1.4 milestone Mar 17, 2023
@arthurpalves
Copy link
Member

Todo: Update params template so that auto generated/updated are below and provide comments so that users know what can/should be manually changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request more information required
Projects
None yet
Milestone
Release 1.2.1
Development

No branches or pull requests
3 participants
@arthurpalves @gderaco @bb-jeriel