Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Code Quality] Improve test coverage to 80% #334

Open
eltntawy opened this issue Jun 12, 2023 · 7 comments
Open

[Enhancement][Code Quality] Improve test coverage to 80% #334

eltntawy opened this issue Jun 12, 2023 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@eltntawy
Copy link
Contributor

Increase test coverage to 80%

  • Add more test case for stream core services
@eltntawy eltntawy added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 12, 2023
@arpitsodani15
Copy link

Hello, I would be happy to pick this up. I need more context what are the stream core services?

@arpitsodani15
Copy link

I am trying to build the application but maven is not able to find this artifact. Can you provide some help?

Could not find artifact com.backbase.buildingblocks:backbase-parent:pom:15.2.0 in central (https://repo.maven.apache.org/maven2)

@eltntawy
Copy link
Contributor Author

Hi @arpitsodani15
you can start from here https://sonarcloud.io/component_measures?id=com.backbase.stream%3Astream-services&metric=coverage&view=list
follow sonar quality coverage and write unite test for uncovered code

@jjjasper
Copy link
Contributor

Hi @arpitsodani15

You will need to add repo.backbase.com repository to your maven configuration. com.backbase.buildingblocks is Backbase SSDK and it is not available on repo.maven.apache.org

@arpitsodani15
Copy link

Hi @jjjasper
I think I need access for repo.backbase.com
Also can you provide me details on what to add in settings.xml file so this repo becomes available.

Hi @eltntawy
I will start working on this once I am able to build the project once.

@jjjasper
Copy link
Contributor

@arpitsodani15 access to repo.backbase.com is limited to Backbase employees, partners and customers. If you are involved in a Backbase project in either of these ways you can get access via that way. I cannot give you access.

@arpitsodani15
Copy link

@eltntawy I think I cannot complete this task without access and according to @jjjasper I cannot get the access.
Thanks anyways, I checked the code and thought of learning about Reactive programming. That would help in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Development

No branches or pull requests

3 participants