Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for setting rateChangeTimes #35

Open
m-d-grunnill opened this issue Oct 3, 2024 · 4 comments
Open

Documentation for setting rateChangeTimes #35

m-d-grunnill opened this issue Oct 3, 2024 · 4 comments

Comments

@m-d-grunnill
Copy link

m-d-grunnill commented Oct 3, 2024

As rateChangeTimes cannot be set in BEAUti, documentation on how to set these in an xml would be good. For instance, how do the Boolean values in the reverseTimeArrays map to BDSky parameters.

@gavryushkina
Copy link
Contributor

@m-d-grunnill
Copy link
Author

m-d-grunnill commented Oct 7, 2024

Thanks! This does go some of the way to explain but no quite all.

How does the order for the boolean values in rateChangeTimes corresponding for the BDSKY serial parameters. https://github.com/BEAST2-Dev/bdsky/blob/master/doc/how_to.pdf mentions the BDSKY serial parameters in the order R, δ, and s in the 3rd paragraph. Is this the order used for boolean values in rateChangeTimes. It is not explicitly stated.

Likewise, the 4th paragraph mention the parameters used in other BDSKY models as λ, µ, ψ, ρ, and r in that order. Is that the order used in the rateChangeTimes boolean values for BDSKY models using that parameterization.

@m-d-grunnill
Copy link
Author

Another point of confusion!

I was looking at xmls from article supporting materials. At line 161 the xml linked below lists 5 boolean values. Yet the BDSKY model is using the 3 parameter parameterization R, δ, and s.

https://github.com/HIVMolEpi/TRIP_Ukraine/blob/master/Kyiv.xml

@jugne
Copy link
Contributor

jugne commented Oct 10, 2024

This could be better documented. But to answer your immediate question from the code:

public Input<BooleanParameter> reverseTimeArraysInput = new Input<BooleanParameter>("reverseTimeArrays", "True if the time arrays are given in backwards time (from the present back to root). Order: 1) birth 2) death 3) sampling 4) rho 5) r. Default false." + "Careful, rate array must still be given in FORWARD time (root to tips). If rhosamplingTimes given, they should be backwards and this should be true.");

This is for birth-death parameterisation. For R, δ, and s parameterisation the order will be: 1) R 2) δ 3) s 4) rho 5) r.

In the analysis you pointed to, rho and r are not specified and thus assume default values of 0 and 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants