Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDSKY depends on SA package #18

Open
rbouckaert opened this issue Feb 1, 2017 · 3 comments
Open

BDSKY depends on SA package #18

rbouckaert opened this issue Feb 1, 2017 · 3 comments

Comments

@rbouckaert
Copy link
Contributor

The BDSKY package contains templates for sampled ancestor analyses that depend on having the SA package installed. Either these templates should be moved to the SA package, or there should be a dependency added to the version.xml file. For now, I added a dependency in the packages.xml file in CBAN.

@gavryushkina
Copy link
Contributor

gavryushkina commented Feb 6, 2017

This is caused by Sampled ancestor operators and SampledAncestorLogger which is in SA package.

@gavryushkina
Copy link
Contributor

If we move the template to the SA package then it will depend on BDSKY.

@walterxie
Copy link
Contributor

Please note: examples/SABDSKY_sequential.xml is using SA operators. I moved it to a sub-folder "SA" under "example" folder, as a temporary solution. It will not be tested by ExampleXmlParsingTest

I also commented out BEASTLab class path in build.xml.

walterxie added a commit that referenced this issue May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants