Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove declaration of plugin_ids in the _init_catalog method when called in CatalogBase.initialize #207

Open
dschristianson opened this issue Sep 26, 2024 · 3 comments
Labels
question Further information is requested

Comments

@dschristianson
Copy link
Contributor

In the core.catalog.CatalogBase.initalize method, a list of plugin_ids is passed to the _init_catalog method (which is specific to the type of catalog being used:

self._init_catalog(plugin_ids=self._plugin_ids)

In the CatalogSqlAlchemy._init_catalog method, I cannot see where the list of plugin_ids passed in is used.

Also, the CatalogDjango (in django-basin3d) also does not currently make use of such a list.

Thus, does the parameter actually need to be passed in?

@dschristianson dschristianson added the question Further information is requested label Sep 26, 2024
@vchendrix
Copy link
Contributor

@dschristianson it does not need to be passed in.

@dschristianson
Copy link
Contributor Author

OK, thanks. My sense is that we change in a future release.

@dschristianson dschristianson changed the title Is passing plugin ids to the _init_catalog method needed? Remove declaration of plugin_ids in the _init_catalog method when called in CatalogBase.initialize Sep 26, 2024
@vchendrix
Copy link
Contributor

OK, thanks. My sense is that we change in a future release.

agreed. It may give us more flexibility in the long run with catalog configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants