Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check typing for PluginMount.plugins in plugin.py #203

Open
dschristianson opened this issue Sep 23, 2024 · 0 comments
Open

Check typing for PluginMount.plugins in plugin.py #203

dschristianson opened this issue Sep 23, 2024 · 0 comments

Comments

@dschristianson
Copy link
Contributor

My IDE is complaining that the plugin type is a str instead of DataSourcePluginPoint. Therefore in the lines below that call the method plugin.get_meta() is not valid because it thinks plugin is a str.

In the plugin.py module, the PluginMount.plugins element (line 224) is defined as a Dict[DataSourcePluginPoint, str]. So it seems like potentially, the for loop here should be for plugin, name in PluginMount.plugins.items().

BUT none of our tests are failing which means the catalog is being initialized correctly. Not sure what is going on.

Originally posted by @dschristianson in #201 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant