Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy issues in newer version #165

Open
dschristianson opened this issue Jul 6, 2023 · 1 comment
Open

mypy issues in newer version #165

dschristianson opened this issue Jul 6, 2023 · 1 comment
Labels
BASIN-3D bug Something isn't working

Comments

@dschristianson
Copy link
Contributor

dschristianson commented Jul 6, 2023 •
edited
Loading

Describe the bug
mypy has errors in newer version

To Reproduce
From GitHub actions run:
mypy -p basin3d --python-version 3.9

basin3d/core/synthesis.py:106: error: Missing named argument "data" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:106: error: Missing named argument "messages" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:269: error: Missing named argument "messages" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:280: error: Missing named argument "data" for "SynthesisResponse"  [call-arg]
basin3d/core/synthesis.py:280: error: Argument "messages" to "SynthesisResponse" has incompatible type "list[Optional[SynthesisMessage]]"; expected "list[SynthesisMessage]"  [arg-type]

Expected behavior
These errors should be corrected or the check disabled in this special case.

GitHub Actions

  • Python 3.8, 3.9 (probably 3.10)
@dschristianson dschristianson added the bug Something isn't working label Jul 6, 2023
dschristianson added a commit that referenced this issue Jul 6, 2023
@dschristianson
Addressed mypy issues with new version
ae57d59 
Issue #165

-- corrected type definition
-- ignored check in select cases for now
@dschristianson dschristianson mentioned this issue Jul 6, 2023
Merged
11 tasks
@dschristianson
Copy link
Contributor Author

For now, ignored mypy call-arg errors until further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BASIN-3D bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vchendrix @dschristianson