-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Region auto enable on env variable #7328
Comments
MSALJS does not use the |
Can you please adapt the feature request to MSAL JS API. It's should not be that different ? Happy to review,. |
@bgavrilMS According to your acceptance tests, I think I don't even need to check for the value of the passed in region. If it exists at all, then it overrides the environment variable. Is that correct? It doesn't matter if it's passed in with a value of "DisableMsalForceRegion" or "alskdjh". However if it is "DisableMsalForceRegion", then I'll need to set it to I was able to pass the three acceptance tests listed above with the code
but I don't think this is the functionality you're looking for. |
Using the ternary operator : there makes the code hard to read. Consider refactoring with If the region API is set to |
Region auto-enable
MSAL_FORCE_REGION
, which will be set to a specific region (e.g.westus1
)Disabling the behavior
If region is explicitly set in MSAL to the string "DisableMsalForceRegion`, then the above no longer applies
Conflicts with
WithAzureRegion(xyz)
Use of the api
WithRegion(xyz)
takes precedence over the env variable.Acceptance tests
For all of the tests, assume env variable MSAL_FORCE_REGION=eastus
Original issue:
AzureAD/microsoft-authentication-library-for-dotnet#4930
The text was updated successfully, but these errors were encountered: