Missing finally block in Vue 3 sample #4262
justgrumpy
started this conversation in
Feedback
Replies: 1 comment
-
@justgrumpy Thanks for the tip, and feel free to open a PR showing this change. cc @tnorling |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I believe the
localInProgress.value = false;
in the useMsalAuthentication.ts file in the vue3-sample-app should be in afinally
block.microsoft-authentication-library-for-js/samples/msal-browser-samples/vue3-sample-app/src/composition-api/useMsalAuthentication.ts
Line 63 in 8afb0be
If there is no finally block to set
localInProgress
to false at the very least after logging in thisreturn
is hitmicrosoft-authentication-library-for-js/samples/msal-browser-samples/vue3-sample-app/src/composition-api/useMsalAuthentication.ts
Line 45 in 8afb0be
acquireToken
will not behave as expected since it will appear to always be in progress.Beta Was this translation helpful? Give feedback.
All reactions