Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Can not call discovery and retrieve metadata via HTTP/2 any more #1980

Open
1 task done
nfarrokhi opened this issue Dec 8, 2022 · 2 comments · May be fixed by #2809
Open
1 task done

[Bug] Can not call discovery and retrieve metadata via HTTP/2 any more #1980

nfarrokhi opened this issue Dec 8, 2022 · 2 comments · May be fixed by #2809
Labels
Customer reported Indicates issue was opened by customer Enhancement The issue is a new feature
Milestone

Comments

@nfarrokhi
Copy link

Which version of Microsoft.IdentityModel are you using?
6.15.1

Where is the issue?

  • M.IM.Protocols

Is this a new or an existing app?

a. The app exists and I have upgraded to a new version of Microsoft.IdentityModel.* I got new version after updating Microsoft.AspNetCore.Authentication.JwtBearer to v 7.0.0

Repro

Try to expose discovery endpoint, which only works on HTTP/2

Expected behavior
Being able to call discovery endpoint and get metadata using HTTP/2

Actual behavior

Call to discovery endpoint to get metadata is only done via HTTP/1.1

Possible solution

Change the code on https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Protocols/Configuration/HttpDocumentRetriever.cs#L123 using one of these solutions:

  1. Set httpRequest.Version to httpClient.DefaultRequestVersion.
  2. Provide an option/setting to be able to set the httpRequest.Version
  3. Revert back HttpDocumentRetriever code to use HttpClient.GetAsync
@brentschmaltz
Copy link
Member

brentschmaltz commented Dec 12, 2022

@nfarrokhi I understand 1 and 2, but am not following 3.
Can you help us out?

@brentschmaltz brentschmaltz added Enhancement The issue is a new feature Customer reported Indicates issue was opened by customer labels Dec 12, 2022
@brentschmaltz brentschmaltz added this to the December refresh milestone Oct 10, 2023
@prochnowc
Copy link

I've created PR #2809 to address this problem, also mentioned in #2808

@pmaytak pmaytak modified the milestones: December refresh, 8.1.0 Sep 23, 2024
@pmaytak pmaytak modified the milestones: 8.1.0, 8.2.0 Sep 25, 2024
@jennyf19 jennyf19 modified the milestones: 8.2.0, 8.2.1 Nov 2, 2024
@pmaytak pmaytak modified the milestones: 8.2.1, 8.3.0 Nov 14, 2024
@jennyf19 jennyf19 modified the milestones: 8.3.0, 8.3.1 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer reported Indicates issue was opened by customer Enhancement The issue is a new feature
Projects
None yet
5 participants