From 4a2ef89da02b9d76e9cf21b987ac49bf1bd3df72 Mon Sep 17 00:00:00 2001 From: Charlie McBride Date: Tue, 7 Nov 2023 17:14:57 -0800 Subject: [PATCH] turn off ApprovalComment trigger for now --- .github/workflows/e2e-matrix-trigger.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/e2e-matrix-trigger.yaml b/.github/workflows/e2e-matrix-trigger.yaml index 78c71451b..36bc5d982 100644 --- a/.github/workflows/e2e-matrix-trigger.yaml +++ b/.github/workflows/e2e-matrix-trigger.yaml @@ -5,17 +5,14 @@ on: branches: [main] pull_request_review: # TODO(charliedmcb): come back to this and factor out the E2E trigger like AWS and clean it up types: [submitted] - workflow_run: - workflows: [ApprovalComment] - types: [completed] permissions: id-token: write # This is required for requesting the JWT contents: read # This is required for actions/checkout jobs: e2e-matrix: - if: (github.event_name != 'pull_request_review' && github.event_name != 'workflow_run') || (github.event_name == 'pull_request_review' && startsWith(github.event.review.body ,'/test')) || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') + if: github.event_name != 'pull_request_review' || startsWith(github.event.review.body ,'/test') uses: ./.github/workflows/e2e-matrix.yaml secrets: E2E_CLIENT_ID: ${{ secrets.E2E_CLIENT_ID }} E2E_TENANT_ID: ${{ secrets.E2E_TENANT_ID }} - E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }} + E2E_SUBSCRIPTION_ID: ${{ secrets.E2E_SUBSCRIPTION_ID }} \ No newline at end of file