Expose github.com/Azure/azure-sdk-for-go/sdk/internal/log package so that custom policy can print log

[MartinForReal]

Feature Request

In current design, custom policy which is out of github.com/Azure/azure-sdk-for-go/sdk module cannot import log package.
It is hard to debug policy without any log.

I'm wondering if we could expose this package for custom policy. Thanks!

[jhendrixMSFT]

If you just need access to the Event type it can be found in the azcore/log package.

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/log/log.go#L15

[github-actions]

Hi @MartinForReal. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[MartinForReal]

I want to invoke log.write function in custom policy to print some info. It would be great if log package can be exposed to public.

[jhendrixMSFT]

Thanks for clarifying.

Can we get more info about your scenario? The SDK's logging facility wasn't meant to be general-purpose, but for SDK authors.

[MartinForReal]

A throttled policy was implemented in cloud provider. https://github.com/kubernetes-sigs/cloud-provider-azure/blob/master/pkg/azclient/policy/ratelimit/flowcontrol/throttle.go And I just want to print some logs. With these log entries, I can confirm that the request was not sent.

[JeffreyRichter]

Joel is correct.
The built-in log policy is for logging HTTP request/replies and is NOT intended to be a general purpose log mechanism. Customers initialize our log policy by passing a callback function to the log policy options when invoking a Client constructor. Your own policy can also take the same (or a different) log callback function in its ctor just as easily and then invoke whatever callback its initialized with. Use the same callback to unify all entries to a single log or use a different callback for a different log.