Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow UltraHonk to handle public inputs #579

Closed
ledwards2225 opened this issue Jul 5, 2023 · 0 comments · Fixed by #581
Closed

Allow UltraHonk to handle public inputs #579

ledwards2225 opened this issue Jul 5, 2023 · 0 comments · Fixed by #581
Assignees

Comments

@ledwards2225
Copy link
Collaborator

Honk requires all polynomials for which we need a shift to have constant coefficient equal to zero. For standard Honk, the only polynomial that is shifted is the grand product, for which we enforce z[0] = 0. For UltraHonk we shift many more polynomials, including the wires. Since PI are placed at the beginning of the coefficient arrays, the constant coefficients will in general not be zero. A hack solution is to simply add 0 as the first PI in all circuits. A better solution may be to simply place the PI at the second position instead of the first, effectively leaving a row of zeros in the execution trace. More generally, we can define a public_inputs_offset specifying the shift the placement of the PI. For goblin, this value will be equal to the number of ecc op "gates" since these will live at the start of the execution trace.

@ledwards2225 ledwards2225 self-assigned this Jul 5, 2023
@ledwards2225 ledwards2225 linked a pull request Jul 17, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant