Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Achievements with an API call as the only condition always show 0% #103

Open
UsernamesAreNotMyThing opened this issue Oct 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@UsernamesAreNotMyThing
Copy link

Describe the bug
Achievements that have an API call as the only condition always appear as 0% in the list, regardless of actual progress.

Expected behavior
The displayed percentage should reflect the progress on the API call condition.

Screenshots
Screenshot_20231016-125959

Environments and Version (please complete the following information):

  • OS: Android 10
  • Version 1.93 (was occurring before this update as well)
@UsernamesAreNotMyThing UsernamesAreNotMyThing added the bug Something isn't working label Oct 16, 2023
@Ayagikei
Copy link
Owner

Thanks for the feedback!

We will look into it asap.

@Ayagikei
Copy link
Owner

Hello, I tried to use the item to test the API, but could not reproduce the problem.

We need to confirm, are you using an external tool such as Tasker to call the API?

v1.93.0-rc02 We checked the relevant code and found that there is logic at the code level to update the overall achievement progress. But it and updating the progress of a single condition belong to two processes and are executed by a dedicated single thread. Then fixed an issue that could cause progress calculation errors.

We're not sure yet whether this is caused by single-thread blocking or something else.

@UsernamesAreNotMyThing
Copy link
Author

Yes, this problem is specifically with the External API Call condition when "running" it from automation apps like Tasker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants