New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify use of `prefunded` parameter to callbacks #127

Open

0xJem opened this issue Apr 5, 2024 · 0 comments

Contributor

0xJem commented Apr 5, 2024

Inspired by sherlock-audit/2024-03-axis-finance-judging#16

We use the prefunded parameter to indicate if the callback should send tokens, when that's actually determined by the send base tokens flag.

e.g. Not prefunded, send base tokens true, prefunded true: https://github.com/sherlock-audit/2024-03-axis-finance/blob/cadf331f12b485bac184111cdc9ba1344d9fbf01/moonraker/src/AuctionHouse.sol#L265

Not prefunded, send base tokens false, prefunded true: https://github.com/sherlock-audit/2024-03-axis-finance/blob/cadf331f12b485bac184111cdc9ba1344d9fbf01/moonraker/src/AuctionHouse.sol#L295

We should clarify what it actually means

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment