Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #123

Open
kmturley opened this issue Nov 21, 2020 · 8 comments · May be fixed by #173
Open

TypeScript support #123

kmturley opened this issue Nov 21, 2020 · 8 comments · May be fixed by #173
Assignees

Comments

@kmturley
Copy link

kmturley commented Nov 21, 2020

According to GitHut, TypeScript is now the #5th most popular language on github:
https://madnight.github.io/githut/#/pull_requests/2020/3

Can you either add types directly to the package or update documentation on how to do it manually?

npm install cli-table
npm install --save @types/cli-table

tsconfig.json

{
  "compilerOptions": {
    "esModuleInterop": true
  }
}

index.ts

import Table from 'cli-table';

You'll save every developer 10 minutes :)

@chrean chrean self-assigned this Dec 6, 2020
@chrean
Copy link
Contributor

chrean commented Dec 6, 2020

Good suggestion @kmturley . A PR would be even more welcome if you feel like you want to contribute. :)

@yakesho
Copy link

yakesho commented Jul 27, 2021

Any updates on this? I can submit a PR if you like. I can also port this for Deno if you like. Porting might take sometimes but for the TS, I can finish it this week

@chrean
Copy link
Contributor

chrean commented Jul 28, 2021

@yakesho a PR would be great, thank you! :)

@yakesho
Copy link

yakesho commented Jul 28, 2021

@chrean The project seems to use old JavaScript syntax. Mind if I change it and use ES6 syntax? (e.g. class, const, etc...)

@chrean
Copy link
Contributor

chrean commented Jul 28, 2021

That's quite a task but much appreciated if you like to contribute!

@yakesho
Copy link

yakesho commented Jul 28, 2021

One more thing, expresso seems unmaintained. Mind if I use a newer and maintained test framework (like mocha or jest). Other than that, I am already working on the project (just to let you know)

@chrean
Copy link
Contributor

chrean commented Jul 28, 2021

Switching to jest was in my plans but then I got caught away with other stuff, so that'd be great.

@antonilol
Copy link

antonilol commented Sep 6, 2022

i have just updated (not merged yet) @types/cli-table. i will also add them here but i expect that a pr to DefinitelyTyped gets merged faster :)

EDIT: merged now

@antonilol antonilol linked a pull request Sep 6, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants