Skip to content
This repository has been archived by the owner on Feb 6, 2022. It is now read-only.

Current build breaks sourcemaps in older browsers #81

Open
kayone opened this issue Aug 25, 2016 · 4 comments
Open

Current build breaks sourcemaps in older browsers #81

kayone opened this issue Aug 25, 2016 · 4 comments

Comments

@kayone
Copy link

kayone commented Aug 25, 2016

right now, the unminified build libjass.js has sourcemap url information at the end of the file,

//# sourceMappingURL=libjass.js.map

This confuses the some old browsers (Samsung Tizen SDK). Inspector will think that's where it should get the sourcemap from and if it fails to load (404) it'll give up on loading anymore sourcemaps for the rest of the app, practically nuking the sourcemaps support.

As far as I can tell there shouldn't be a need for the unminified version of the file to have any sourcemap information included.

@kayone kayone changed the title Current build breaks sourcemaps in older browsers, Current build breaks sourcemaps in older browsers Aug 25, 2016
@Arnavion
Copy link
Owner

As far as I can tell there shouldn't be a need for the unminified version of the file to have any sourcemap information included.

The sourcemap maps the JS to the original TS. Same for the minified version.

I personally don't need it; I have no problem debugging JS. But rather than me removing it to cater to a buggy browser, perhaps you could strip it out on your end?

@kayone
Copy link
Author

kayone commented Aug 26, 2016

I completely understand, that's what we do right now, however it means we can't use the NPM package anymore.

@Arnavion
Copy link
Owner

Well I meant something like a build step, but I'll think about it.

@kayone
Copy link
Author

kayone commented Aug 26, 2016

yeah, that was our next step, in case another library does something similar.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants