Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you auto push autopilotmega.xml on a schedule to mavlink/mavlink? #375

Open
hamishwillee opened this issue Nov 14, 2024 · 6 comments
Open

Comments

@hamishwillee
Copy link

hamishwillee commented Nov 14, 2024

We just got a clash in mavlink#2174 because development.xml was assigned an ID that was used by ArduPilotmega.xml some months ago.

Now the value development was defined in the wrong range but would be good if we could catch earlier.

Having most up to date dialects would help with that. Is it possible to push ardupilotmega up on a cycle using a workflow?

@Davidsastresas
Copy link

I second this, thanks @hamishwillee. For awareness @rmackay9

@hamishwillee
Copy link
Author

@peterbarker I fixed this using a workflow in mavlink/mavlink - mavlink#2177, resulting in first PR mavlink#2178

This just fetches ardupilotmega.xml, but that dialect depends on a number of others (loweheiser.xml) is new to me. Which of these are managed as part of the ardupilot project? I.e. the "master" version is seen to be the one in ArduPilot/mavlink.

  <include>uAvionix.xml</include>
  <include>icarous.xml</include>
  <include>loweheiser.xml</include>
  <include>cubepilot.xml</include>
  <include>csAirLink.xml</include>

@hamishwillee
Copy link
Author

A bit messy - just got caught because MAV_CMD_EXTERNAL_POSITION_ESTIMATE moved into common upstream, but not here - so we ended up with clashes.

@khancyr
Copy link

khancyr commented Dec 4, 2024

I think this is possible technically. One issue is that GitHub disable programmed action if the repo has low or no activity for some time...but we should be able to manage this.

I will try to look on this issue to maintain a sync between repos

@Davidsastresas
Copy link

That would be awesome, thank you @khancyr!

@hamishwillee
Copy link
Author

hamishwillee commented Dec 4, 2024

Thanks @khancyr - if you or @auturgy or @amilcarlucas can keep this repo in-sync with the upstream repo (as far as you) can that would be great (I am then happy to pull the ardupilot-managed xml up to mavlink/mavlink on a schedule).

On way to do this is how PX4 takes the mavlink repo. There is a scheduled github action that creates a PR and updates it with any changes (if there are any). The PR sits there being updated for weeks/months until someone is ready to merge.
YOu could do this similarly, and then review/do late fixes before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants