[Bugfix] instance.UI.setActiveLeftPanel not working in modular UI #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concrete data-element identifier like "thumbnailsPanel" are obviously not included
in a collection that consists of objects that have the form
{
dataElement ...,
location ...
render: ...
}
So mapping these down to the dataElement should make the inclusion check work again :)
|
Uhh, quickly switched back to 10.10 as base as switching to master showing some strange diffs. Hit me up if I should change the base/PR to your desired target! 🙂 |
|
It might need further testing, as I think there are some troubles with the left panel not showing up correctly after my change. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concrete data-element identifier like "thumbnailsPanel" are obviously not included in a collection that consists of objects that have the form
So mapping these down to their dataElement property should make the inclusion check work again :)
I ran
npm run lintbefore but because of just a single changed line I think there isn't much work to be done here 😄