Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Multi-stage builds instead of Makefile for Dockerfile #6

Open
YummYume opened this issue Jan 7, 2025 · 1 comment
Open

Use Multi-stage builds instead of Makefile for Dockerfile #6

YummYume opened this issue Jan 7, 2025 · 1 comment
Assignees

Comments

@YummYume
Copy link

YummYume commented Jan 7, 2025

Hello ! So happy to finally see a web version that we can self-host. Thanks a lot 🙏

One thing that seems particularly weird though is the usage of a Makefile to build the project and then copy the dist result to the Dockerfile. A better way to do this would be to use multi-stage builds to first build the project with the dist folder and then copy it over to the final image.

This would be especially useful since it means we wouldn't have to install pnpm or anything else on the host machine, and it would also be useful when using tools like Coolify, where we can simply supply the Dockerfile to use and everything works out of the box. It would also make it easier to manage env variables that we want to pass during the build process, instead of relying only on a .env file.

@khorshuheng
Copy link
Collaborator

Yes, i am currently working on this and will be updating the guide soon.

@khorshuheng khorshuheng self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants