Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Governance contract, Query bug #32

Open
kaisbaccour opened this issue Mar 5, 2022 · 0 comments
Open

[BUG] Governance contract, Query bug #32

kaisbaccour opened this issue Mar 5, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@kaisbaccour
Copy link

Hey guys, I Found this issue while copying your code to terra-vegas casino
This issue is a confusing query issue in the governance contract.
The confusion happens in this line
https://github.com/Anchor-Protocol/anchor-token-contracts/blob/main/contracts/gov/src/contract.rs#L598

This happens when the voting period is finished but no tx has happened yet to update the state.
This could be mitigated by adding a new condition on the query function to make sure we send the right response.
I opened a PR here #31
I put the Status to Expired because I did not want to add a new PollStatus::WaitingOnTransactionToEndPoll. But I believer a new status should be there to better describe the Poll status (Waiting On Transaction To End Poll)

Please check the Pull request

@kaisbaccour kaisbaccour added the bug Something isn't working label Mar 5, 2022
@kaisbaccour kaisbaccour changed the title [BUG] title_of_bug [BUG] Governance contract, Query bug Mar 5, 2022
@Anchor-Protocol Anchor-Protocol deleted a comment Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant