Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary 2 issues #14459

Closed
mlqn opened this issue Jan 20, 2025 · 1 comment · Fixed by #14470, #14460 or #14473
Closed

Summary 2 issues #14459

mlqn opened this issue Jan 20, 2025 · 1 comment · Fixed by #14470, #14460 or #14473
Labels
added-to-sprint area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. team/studio-domain2

Comments

@mlqn
Copy link
Contributor

mlqn commented Jan 20, 2025

Description of the bug

1. Select current layout set as default layout set

When I add a summary2 component into Activity_11ue45w, the default/selected layoutset should be Activity_11e45w, not form

2. Update components list in the Overrides section based on the selected layout set

The component list of the Overrides section always shows the list of the current layout set. It should rather show the list of components of the selected layoutset set.

3. Filter components list based on type

The components list should probably exclude the components that can’t be used in a summary

altinn-studio/frontend/packages/ux-editor/src/components/config/componentSpecificContent/Summary2/Summary2Target/targetUtils.ts

Lines 7 to 28 in 5a38a96

const excludedComponents = [
ComponentType.ActionButton,
ComponentType.Alert,
ComponentType.AttachmentList,
ComponentType.Button,
ComponentType.ButtonGroup,
ComponentType.CustomButton,
ComponentType.Grid,
ComponentType.Header,
ComponentType.IFrame,
ComponentType.Image,
ComponentType.InstantiationButton,
ComponentType.InstanceInformation,
ComponentType.Link,
ComponentType.NavigationBar,
ComponentType.NavigationButtons,
ComponentType.Panel,
ComponentType.Paragraph,
ComponentType.PrintButton,
ComponentType.Summary,
ComponentType.Summary2,
];

Steps To Reproduce

summary2-issues.mov

Additional Information

No response
@mlqn mlqn added kind/bug Used when there is a defect / something is not working as it should. status/triage labels Jan 20, 2025
@mlqn mlqn added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. added-to-sprint team/studio-domain2 and removed status/triage labels Jan 20, 2025
@mlqn mlqn moved this to 📈 Todo in Team Studio Jan 20, 2025
@Jondyr Jondyr moved this from 📈 Todo to 👷 In Progress in Team Studio Jan 20, 2025
@Jondyr Jondyr mentioned this issue Jan 20, 2025
Merged
4 tasks
This was linked to pull requests Jan 21, 2025
feat: summary2 filter override components #14470
Merged
feat: reorganize summary2 config #14460
Merged
@Jondyr Jondyr mentioned this issue Jan 21, 2025
Merged
4 tasks
@Jondyr Jondyr linked a pull request Jan 21, 2025 that will close this issue
fix: summary2 set correct layoutset as default #14473
Merged
4 tasks
@Jondyr Jondyr mentioned this issue Jan 21, 2025
Merged
4 tasks
@Jondyr
Copy link
Member

Jondyr commented Jan 21, 2025 •
edited
Loading

These PRs should be tested together in #14473

@Jondyr Jondyr moved this from 👷 In Progress to 🔎 Review in Team Studio Jan 22, 2025
@Jondyr Jondyr removed their assignment Jan 22, 2025
@mlqn mlqn moved this from 🔎 Review to 🧪 Test in Team Studio Jan 27, 2025
@lassopicasso lassopicasso self-assigned this Jan 27, 2025
@github-project-automation github-project-automation bot moved this from 🧪 Test to Documentation in Team Studio Jan 28, 2025
@lassopicasso lassopicasso removed their assignment Jan 28, 2025
@lassopicasso lassopicasso moved this from Documentation to ✅ Done in Team Studio Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
added-to-sprint area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/bug Used when there is a defect / something is not working as it should. team/studio-domain2
Projects
Team Studio
Status: ✅ Done
Milestone
No milestone
3 participants
@Jondyr @mlqn @lassopicasso