no startrails

[macsmith]

startrails are not being generated. I've tried invoking the startrails script but get an error message:

pi@allsky:~/allsky $ ./startrails -b 0.07 -d ./images/20211109/ -e jpg -o startrails.jpg

which generates an output error message:

_Output file 'startrails.jpg' is missing extension (.jpg or .png)

Usage: startrails [-v] -d <dir> -e <ext> [-b <brightness> -o <output> | -S] [-s <WxH>] [-Q <max-threads>] [-q <nice>]
Source directory and file extension are always required.
brightness threshold and output file are required to render startrails_

Any help woud be appreciated. Not sure exactly which version I'm running but I downloaded and installed it in October (2021) on a Pi 4

Thanks
Ian

[linuxkidd]

Hi Ian,
This was a short lived bug in the startrails code. It was fixed a bit ago now. I would recommend running the upgrade script to come up to the latest code.

Thanks!

[linuxkidd]

It's possible.

Can you run the following and provide the output to confirm if the code is fixed on your install:

head -n 335 ~pi/allsky/src/startrails.cpp | tail -n 10

[macsmith]

here's the output:

 if (config.startrails_enabled) {
    std::string extcheck = config.dst_startrails;
    std::transform(extcheck.begin(), extcheck.end(), extcheck.begin(),
                   [](unsigned char c) { return std::tolower(c); });

    if (extcheck.rfind(".png") == string::npos ||
        extcheck.rfind(".jpg") == string::npos) {
      fprintf(stderr,
              KRED "Output file '%s' is missing extension (.jpg or .png)\n\n",

[linuxkidd]

Ya, that code still has the bug. This line here:

    if (extcheck.rfind(".png") == string::npos ||

Should be changed to:

    if (extcheck.rfind(".png") == string::npos &&

The new code in the repo has this fix.

[macsmith]

ok,
many thanks, will do.
Ian

[macsmith]

it worked! Wonderfull startrails :-)

Many thanks
Ian