Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Flaw (In Dark-mode): (×) Symbol appears which should not be there and NaN error message font needs adjustment for dark-theme #94

Open
Pratham-Onkar-Singh opened this issue Oct 13, 2024 · 2 comments
Assignees

Comments

@Pratham-Onkar-Singh
Copy link
Contributor

Pratham-Onkar-Singh commented Oct 13, 2024

Issue Description: When switching to dark mode, an unnecessary (×) symbol appears on certain UI elements, which should not be displayed. Additionally, the font for the NaN error message does not adjust appropriately for dark mode, making it inconsistent with the overall theme.

Expected Behavior:

  • The (×) symbol should not be visible in dark mode.
  • The NaN error message font should adjust to be consistent with the dark mode theme, ensuring readability and visual harmony.

Steps to Recreate:

  • Go to the website Binary Calculator.
  • Switch from light mode to dark mode.
  • Observe the appearance of the (×) symbol in places where it shouldn't be.
  • Trigger a NaN error message (example- by clicking on octal without typing anything) and observe that its font does not align with the dark mode design(i.e it is not properly readable).

binary

Request: Kindly assign this issue to me (Pratham Onkar Singh) so I can resolve it.

@Pratham-Onkar-Singh
Copy link
Contributor Author

@Alitindrawan24 Please do assign this issue to me(Pratham Onkar Singh) so that i can resolve an annoying visual bug.

@Alitindrawan24
Copy link
Owner

Already assigned @Pratham-Onkar-Singh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants