Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NavBar responsive for Mobile View #508

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make NavBar responsive for Mobile View #508

wants to merge 4 commits into from

Conversation

AshuKV
Copy link
Contributor

@AshuKV AshuKV commented May 22, 2021

Description

Please include a summary of the change and which issue is fixed.
Fixes #487

List any dependencies that are required for this change

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

UI /UX changes

Attach gif or screenshot for changes.

  • Before :
    image
- After :

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

harikesh409
harikesh409 requested changes May 22, 2021
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug still exists and removing the navbar-brand class is not the solution and on removing it the image looks odd.

harikesh409
harikesh409 requested changes May 28, 2021
View reviewed changes
Copy link
Collaborator

@harikesh409 harikesh409 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
The navbar styles are changed on hovering an underline is coming and the color of Phantoms is blue which shouldn't be.
The files are not in sync with the master repo resync it.

css/style.css Outdated Show resolved Hide resolved
css/style.css
@@ -368,6 +368,67 @@ hr {

/******about end ******** */


/********Section-Sharpen your skills starts*********/
.skills-section table {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all these styles are removed in master repo sync with it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not resolved.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT RESOLVED!!

AshuKV
AshuKV commented May 30, 2021
View reviewed changes
Copy link
Contributor Author

@AshuKV AshuKV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the invalid line.

harikesh409
harikesh409 requested changes May 31, 2021
View reviewed changes
css/style.css
@@ -368,6 +368,67 @@ hr {

/******about end ******** */


/********Section-Sharpen your skills starts*********/
.skills-section table {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not resolved.

@AshuKV
Copy link
Contributor Author

AshuKV commented May 31, 2021

Finally its resolved. You can merge the PR now. Thanks

harikesh409
harikesh409 requested changes Jun 1, 2021
View reviewed changes
css/style.css
@@ -368,6 +368,67 @@ hr {

/******about end ******** */


/********Section-Sharpen your skills starts*********/
.skills-section table {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT RESOLVED!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harikesh409 harikesh409 harikesh409 requested changes

Assignees

@AshuKV AshuKV

Labels
changes requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NAVBAR SECTION
2 participants
@AshuKV @harikesh409