Added quiz section #341
Added quiz section #341
Conversation
|
@harikesh409 please review |
|
|
||
| body{ | ||
| font-size: 20px; | ||
| background-color: #000; |
There was a problem hiding this comment.
Don't use black as background color use something which matches our color scheme.
|
|
||
|
|
||
|
|
||
| .container{ |
There was a problem hiding this comment.
You can include bootstrap and use those styles as in our website we are using bootstrap.
css/quiz.css
Outdated
| button:hover{ | ||
| background-color: #3cae3c; | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove unnecessary lines.
css/quiz.css
Outdated
| width:500px; | ||
| background-color: #f1f1f1; | ||
| box-shadow: 0 8px 6px -6px black; | ||
|
|
| " HashMap", | ||
| "List","D"] | ||
| ]; | ||
| function $(arg) { |
There was a problem hiding this comment.
Include jquery and use it.
Quiz.html
Outdated
| </div> | ||
| </div> | ||
| <div class="container"> | ||
| <div class="row well"> |
There was a problem hiding this comment.
well is a bootstrap 3 class use card which is a bootstrap 4 class.
| option = options[i].value; | ||
| } | ||
| } | ||
| if (option == questions[pos][5]) { |
There was a problem hiding this comment.
Declare the variable option in the checkAnswer() or else the option is declared in global scope and if the user didn't give an option and click submit then the previous answer will be store here.
|
|
||
| function checkAnswer() { | ||
| options = document.getElementsByName("options"); | ||
| for (var i = 0; i < options.length; i++) { |
There was a problem hiding this comment.
The whole loop can be simplified using jquery.
css/quiz.css
Outdated
| @@ -0,0 +1,77 @@ | |||
| @import url(https://fonts.googleapis.com/css?family=Work+Sans:300,600); | |||
There was a problem hiding this comment.
If possible remove this files and use the fonts that are already present in css/style.css
|
@Muskan-creator what is the progress and also resolve the merge conflicts. |
|
@harikesh409 please review |
Few comments are not yet addressed. |
Description
Please include a summary of the change and which issue is fixed.
Added a fullly dynamic quiz page of data structure and algorithms in html ,css and javascript when clicking on quizzes section in features tab.
Fixes #328
List any dependencies that are required for this change
Type of change
How Has This Been Tested?
UI /UX changes
Attach gif or screenshot for changes.
Before :
After :
Checklist: