fix: Broken protobuf varint functions, add tests #653
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Fixes #651. I have only looked at the functions locally. I'll leave this in draft until further investigation into why the code that relies on these broken fundamentals is not itself broken. There's a possibility these paths are never exercised, in which case a better course of action is to prune the code.
read_indexes
+write_indexes
.read_varint
+write_varint
.Both these tests fails without patching the functions.
write_varint
was seemingly entirely broken. Replacebytearray
casting with.to_bytes()
invocation.read_indexes
expects first value to be size of array, adjustwrite_indexes
to write length before writing values.read_indexes
special-casedsize == 0
for no apparent reason, this is removed as it looks broken and doesn't have symmetry inwrite_indexes
.