Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to undefined method in SchemaRegistryClient.post_new_schema() #639

Open
aiven-anton opened this issue Jun 1, 2023 · 1 comment
Open

Comments

@aiven-anton
Copy link
Contributor

aiven-anton commented Jun 1, 2023

What happened?

Discovered when working on static type checking coverage.

On this line there's a call to references.json() where references: Reference, however Reference has no .json() method.

https://github.com/aiven/karapace/blob/42b14c71543b878c42c11025ab266122d61550d3/karapace/serialization.py#L92

I tried adding raise NotImplementedError on that line, and confirmed that there is no test coverage there. Presumably, a case should be added to tests/integration/test_client_protobuf.py.

What did you expect to happen?

  • Test suite should be failing.
  • Correct method should be called.
@aiven-anton
Copy link
Contributor Author

cc @libretto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant