Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: bad offers fail silently #21

Open
dckc opened this issue Dec 19, 2023 · 1 comment
Open

UI: bad offers fail silently #21

dckc opened this issue Dec 19, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dckc
Copy link
Member

dckc commented Dec 19, 2023

In #20 , the user can give less than the joinPrice or want more than 3 places. The contract correctly rejects such offers, but the UI does not show the error.

In the console, I see:

ses.js?v=331fbee1:3670 SES_UNHANDLED_REJECTION: Error: Passed Error "stack" {"configurable":false,"enumerable":false,"get":"[Function <anon>]","set":"[Function <anon>]"} must be a string-valued data property.
  at Array.map (<anonymous>)
  at Array.map (<anonymous>)
  at Array.map (<anonymous>)
  at Array.map (<anonymous>)
handleRejection	@	ses.js?v=331fbee1:3670
finalizeDroppedPromise	@	ses.js?v=331fbee1:3594
Show less

@samsiegart you dealt with this in some of our dapps already, yes?
I should be able to find that issue and its fix on my own...

cc @0xpatrickdev

@dckc dckc added the bug Something isn't working label Dec 19, 2023
@samsiegart
Copy link
Contributor

This issue is the same as Agoric/ui-kit#57. It's fixed in the latest release of ui-kit, but it requires updating @agoric/rpc and @agoric/web-components which involves breaking changes. For reference, these are the updates made to dapp-inter to use those new versions

@dckc dckc mentioned this issue Dec 20, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants