Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam files in root #444

Open
giltho opened this issue Oct 30, 2024 · 9 comments · Fixed by #446
Open

opam files in root #444

giltho opened this issue Oct 30, 2024 · 9 comments · Fixed by #446

Comments

@giltho
Copy link

giltho commented Oct 30, 2024

Hello,

Opam requires the opam file to be at the root of the repository to allow installing/pinning the repo.
At the moment, to pin charon, one must clone the repo and pin it locally, it cannot be pinned from github.

Supposedly moving the dune-project file up the hierarchy should be sufficient.

@Nadrieril
Copy link
Member

Nadrieril commented Oct 31, 2024

Hi! That's a good idea, I made a PR that does that: #446

@Nadrieril
Copy link
Member

The PR is merged, could you try to see if that's enough?

@Nadrieril Nadrieril reopened this Oct 31, 2024
@giltho
Copy link
Author

giltho commented Oct 31, 2024

I think you forgot to commit the newly-generated opam files 😬

@Nadrieril
Copy link
Member

Huh, it seems I was running dune from the wrong directory so it didn't regenerate the files. Fixed by #448.

@Nadrieril
Copy link
Member

How about now?

@giltho
Copy link
Author

giltho commented Oct 31, 2024

Almost there! Looks like visitors and name_matcher_parser are missing as dependencies of Charon. There may be more, but I can't install the latter from opam:

image

After installing visitors:
image

@giltho
Copy link
Author

giltho commented Oct 31, 2024

Actually I didn't think enough, I just had to pin name_matcher_parser also
Another missing dependency: easy_logging
And after that it compiles :)

@Nadrieril
Copy link
Member

Nadrieril commented Oct 31, 2024

Amazing! What should I do to register these dependencies correctly (I'm quite unfamiliar with the ocaml packaging ecosystem)?

@giltho
Copy link
Author

giltho commented Nov 1, 2024

They should just be added to the dune-project file, see e.g. https://github.com/bugs-for-all/bfa-ocaml/blob/main/dune-project

And then the opam files need to be regenerated from that and committed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants