Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatching versions & instructions #103

Closed
BarnyShergold opened this issue Aug 14, 2023 · 4 comments
Closed

Mismatching versions & instructions #103

BarnyShergold opened this issue Aug 14, 2023 · 4 comments
Assignees
Labels
done Work on this is finished

Comments

@BarnyShergold
Copy link

Issue in ./help/upgrade/implementation/perform-upgrade.md

This page should be overhauled. It refers to update methods going back to 2.4.1 and also examples and commands have mismatched versions

Example - Minor release
Text refers to 2.4.3 :
Minor releases contain new features, quality fixes, and security fixes. Use Composer to specify a minor release. For example, to specify the Magento Open Source 2.4.3 metapackage:

Instruction refers to 2.4.0
composer require-commerce magento/product-community-edition 2.4.0 --no-update

Example - Quality patch
Text refers to 2.4.1 :
Quality patches primarily contain functional and security fixes. However, they can sometimes contain new, backward-compatible features. Use Composer to download a quality patch. For example, to specify the Magento Open Source 2.4.1 metapackage:

Instruction refers to 2.4.3
composer require-commerce magento/product-community-edition 2.4.3 --no-update

And so on. ALL examples should be updated to refer to a SINGLE commerce version. EG 2.4.6 (as latest)

Also 'composer require-commerce' method throws an error when executed on Composer 2.

Deprecation Notice: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /private/var/www/abb-motions-ecommerce-frankfurt/vendor/magento/composer-root-update-plugin/Utils/PackageUtils.php:128
Deprecation Notice: VersionSelector::findBestCandidate with ignored platform reqs as bool|array is deprecated since Composer 2.2, use an instance of PlatformRequirementFilterInterface instead. in phar:///usr/local/Cellar/composer/2.4.4/bin/composer/src/Composer/Package/Version/VersionSelector.php:80

Normally I use 'composer update magento/product-enterprise-edition' version

Finally, updating on Cloud is slightly different too. This should be mentioned.

@github-project-automation github-project-automation bot moved this to 🆕 Ready for Grooming in Commerce - Issues Aug 14, 2023
@dobooth dobooth moved this from 🆕 Ready for Grooming to 📋 Backlog in Commerce - Issues Aug 31, 2023
@hostep
Copy link
Contributor

hostep commented Oct 12, 2023

Also 'composer require-commerce' method throws an error when executed on Composer 2.

Deprecation Notice: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /private/var/www/abb-motions-ecommerce-frankfurt/vendor/magento/composer-root-update-plugin/Utils/PackageUtils.php:128

That error you're encountering has already been fixed in magento/composer-root-update-plugin@dcbfe8b

However, 11 months later, they still forgot to release that fix in a stable new version ...
I'll ask Stanislav on Slack to take a look.

Update, looks like this was already noticed this some months ago over here: magento/composer-root-update-plugin#36

@jeff-matthews
Copy link
Contributor

@adobe export issue to Jira project COMDOX as Story

@github-jira-sync-bot
Copy link
Collaborator

✅ Jira issue COMDOX-865 is successfully created for this GitHub issue.

@jeff-matthews jeff-matthews self-assigned this Dec 8, 2023
@jeff-matthews jeff-matthews added the in-progress Someone is working on it label Dec 8, 2023
@jeff-matthews jeff-matthews moved this from 📋 Backlog to 🏗 In progress in Commerce - Issues Dec 8, 2023
@jeff-matthews jeff-matthews moved this from 🏗 In progress to 👀 In review in Commerce - Issues Dec 8, 2023
@jeff-matthews
Copy link
Contributor

@BarnyShergold

I addressed the majority of your comments in f87eadc.

The issue with the Composer plugin command appears to be a code issue. Please feel free to open a new issue (or PR) to suggest additional guidance.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Commerce - Issues Dec 12, 2023
@jeff-matthews jeff-matthews added done Work on this is finished and removed in-progress Someone is working on it labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done Work on this is finished
Projects
Archived in project
Development

No branches or pull requests

4 participants