Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid characters for filename are incomplete #3487

Open
anneangersbach opened this issue Dec 3, 2024 · 1 comment
Open

Invalid characters for filename are incomplete #3487

anneangersbach opened this issue Dec 3, 2024 · 1 comment

Comments

@anneangersbach
Copy link

I stumbled across this line because we had to do an overlay in our project for it. I recognised that not all invalid characters for windows are removed (<, >, ").
I want to suggest changing this to a whitelist instead, since not only are there invalid characters that remain, but also the location of valid characters that make them invalid filenames could be an issue (e.g. space or dot at the beginning or end of a filename).

for (char ch : new char[]{'\\', '/', '*', '[', ']', ':', '?'}) {

@YegorKozlov
Copy link
Contributor

@anneangersbach Would you create a pull request to implement these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants