Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscale issue #5: the upscale model selector is not updated when the 1,00x Scale is chosen #1269

Open
valery016 opened this issue Oct 16, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@valery016
Copy link

When the 1,00x Scale is chosen, no upscaling is performed, therefore it would be logical to display ‘None’ instead of the currently displayed 1st model in the list. Similarly, it would make sense to change the ‘Upscale’ button’s label to ‘Refine’ upon user selecting the 1,00x Scale.

@Acly Acly added the enhancement New feature or request label Oct 18, 2024
@Acly
Copy link
Owner

Acly commented Oct 18, 2024

The button label is easy to do.

Kind of disagree on changing the model selection, I think it's fine. UI options the user has specifically selected don't typically change even if they're not used in an operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants