Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scroll bar #45

Closed
shuvashish76 opened this issue Aug 13, 2024 · 6 comments
Closed

Add Scroll bar #45

shuvashish76 opened this issue Aug 13, 2024 · 6 comments
Assignees
Labels
🚀 Feature request New feature request or improvement

Comments

@shuvashish76
Copy link

Why you want this feature to be implemented? Please describe.
Adding scroll bar would allow you to know how long the vertical screen is with respect to current screen, also helps to drag & jump screen quickly.
Add it to reader screen, library, history, browse.. everywhere (only when scroll is necessary) because when we need scrolling better to scroll with a scroll bar :)

Describe alternatives you've considered
Have a look on these libraries

@Acclorite
Copy link
Owner

Thank you for suggestion.

Looks interesting and I don't see minuses on implementing this (if no issues occur).

@Acclorite
Copy link
Owner

Acclorite commented Aug 22, 2024

Sadly there are issues with implementing this.

Thanks for referencing this library, it really works great, but there is one issue — it does not work with LazyListState in ViewModel, which is used in History, Browse and Reader. This basically means no scrollbar on those screens.

I still feel like it is better to have at least that, scrollbar will still be available on most of the screens.

Edit: Discovered more issues with manual scrolling(by holding scrollbar), scrollbar height(dynamically changes when scrolling) and incorrect appearance(scrollbar appears when trying to scroll—even if the list is not long enough to scroll).

Canceled for now, will wait for better solution(such as official implementation from Google).

@Acclorite Acclorite closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Book's Story: Roadmap 🌌 Aug 22, 2024
@Acclorite Acclorite moved this from Done to Awaiting in Book's Story: Roadmap 🌌 Aug 22, 2024
@Acclorite Acclorite added the 🚫 Cannot fix Issue that I cannot fix, due to specified reasons (in most cases) label Aug 22, 2024
@shuvashish76
Copy link
Author

Edit: Discovered more issues with manual scrolling(by holding scrollbar), scrollbar height(dynamically changes when scrolling) and incorrect appearance(scrollbar appears when trying to scroll—even if the list is not long enough to scroll).

Reference to track progress at : nanihadesuka/LazyColumnScrollbar#40

Acclorite added a commit that referenced this issue Aug 24, 2024
Added scrollbar to non-primary screens. Not doable for all screens due to problems.

Partly Resolves: #45
@Acclorite
Copy link
Owner

Reconsidered my approach, partly implemented.
Fixed most issues, added scrollbar to non-primary screens, such as Settings, Help, About.
Although, it is not "primary" scrollbar, but semi-transparent secondary, which cannot be used for scrolling.

@github-project-automation github-project-automation bot moved this from Awaiting to Done in Book's Story: Roadmap 🌌 Aug 24, 2024
@Acclorite Acclorite added ⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release and removed 🚫 Cannot fix Issue that I cannot fix, due to specified reasons (in most cases) labels Aug 24, 2024
@shuvashish76
Copy link
Author

shuvashish76 commented Aug 24, 2024

it is not "primary" scrollbar, but semi-transparent secondary, which cannot be used for scrolling.

So basically it's a "view bar" which use case is: only to see the total screen highest in relation to current screen?

@Acclorite
Copy link
Owner

Acclorite commented Aug 24, 2024

Easier to show haha

Scrollbar.png

Edit: The problem with "primary" scrollbar is when it's height changes dynamically (and it does a lot), it looks really ugly. "Secondary" looks more or less alright, as it does not attract as much attention

@Acclorite Acclorite removed the ⏳ Awaiting release Issue that was resolved in one of the commits and now awaiting release label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Feature request New feature request or improvement
Projects
Status: Done
Development

No branches or pull requests

2 participants