Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement divide-and-conquer algorithm in ll/base.rs #97

Open
Candunc opened this issue Oct 11, 2017 · 1 comment
Open

Implement divide-and-conquer algorithm in ll/base.rs #97

Candunc opened this issue Oct 11, 2017 · 1 comment

Comments

@Candunc
Copy link

Candunc commented Oct 11, 2017

On line 306. there is a todo stating to use a divide and conquer algorithm for large inputs.

In my use case of the library, over 60% of instructions executed according to cargo-profiler belong to the functions from_base and from_base_small. Is there any possibility of this algorithm being implemented in the future, or should I look into using other libraries?

@Aatch
Copy link
Owner

Aatch commented Oct 27, 2017

How big are the numbers in question? The divide-and-conquer algorithm only really helps when you have a lot of digits, like > 1000 in whatever base you're converting from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants