Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester B] Possible invalid input for the address with the / character. #143

Open
nus-pe-script opened this issue Apr 5, 2024 · 1 comment

Comments

@nus-pe-script
Copy link

When you use the keyword a/<address>, you probably should not be able to add a / inside of the address because it should be a reserved character used to mark a prefix for an attribute and, therefore, should probably throw an error ie can not use / inside attribute names as it is a reserved key-character. Instead, it is allowed. You might add new keywords in the future so it's nice to have that in mind.


Labels: type.FeatureFlaw severity.Low
original: TarinPairor/ped#2

@narwhalsilent narwhalsilent added this to the 1.4 milestone Apr 6, 2024
@marcus-ny
Copy link

Good point to consider. Perhaps in the case of a tag following in the command such as a/<address> t/<tags> and if the address has a substring t/ inside of it, what will the error message be?

@marcus-ny marcus-ny added severity.Medium Occasional inconvenience to some users bug.functionality labels Apr 9, 2024
@Joseph31416 Joseph31416 added Planned Enhancement and removed severity.Medium Occasional inconvenience to some users bug.functionality labels Apr 9, 2024
@narwhalsilent narwhalsilent removed this from the v1.4 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants