Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Base.Number as scalar field #18

Open
Benr444 opened this issue Sep 20, 2023 · 2 comments
Open

Support for Base.Number as scalar field #18

Benr444 opened this issue Sep 20, 2023 · 2 comments
Assignees
@ATell-SoundTheory

Comments

@Benr444
Copy link

Benr444 commented Sep 20, 2023

Would it be possible to support scalar multiplication with any Base.Number subtype?

Restriction to Base.Real right now has several issues. The complex scalar Base.im can't be used to define a complexified Clifford Algebra. Also, it restricts the kinds of packages we can interact with--ones like Measurements.jl work (the principle type <: Base.Real) whereas ones like Unitful.jl don't work (the principle type is not a subtype of Base.Real)

You can kind hack together solutions to both of these right now but it's not great. Thanks!
@Benr444
Copy link
Author

Benr444 commented Sep 20, 2023

Also, I love this package so thanks for making it

@ATell-SoundTheory
Copy link
Owner

Thank you for your feedback! Would you be able to make a pull request? I'm insanely busy right now and if you wish this to be added soon then making a PR is probably the fastest way.

@ATell-SoundTheory ATell-SoundTheory self-assigned this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ATell-SoundTheory ATell-SoundTheory

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Benr444 @ATell-SoundTheory