Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flacoco supports parallelisation #92

Open
martinezmatias opened this issue Aug 24, 2021 · 6 comments
Open

Flacoco supports parallelisation #92

martinezmatias opened this issue Aug 24, 2021 · 6 comments

Comments

@martinezmatias
Copy link
Collaborator

martinezmatias commented Aug 24, 2021

We can check if Flacoco supports parallelisation on the same JVM.
We have a singleton in FlacocoConfig that could impact on the parallelisation.

(Point discussed in #91)

@martinezmatias
Copy link
Collaborator Author

Just one thought:
what about adding an instance from FlacocoConfig as input in the run methods from Flacoco class. (The instance would be still created by the Main)
Then, it will pass the instance to the Runner, which will store it in a field (which currently is affected with the singleton ).

That would allow that each runner have one particular configuration.
WDYT?

@andre15silva
Copy link
Member

Ok, yes. I agree with that use case.

I will include that change in #91 .

@andre15silva
Copy link
Member

On a second though, we have to make a design decision:

  • Pass the FlacocoConfig to every class who needs it.
  • Parametrize (almost) every class who needs access to the config and pass only the required ones.

The second option is more OOP, but in some cases this will result in a lot of parameters.

WDYT?

@martinezmatias
Copy link
Collaborator Author

Hi @andre15silva

Both options are fine, but I'd chose the first one as it would be easier to develop and maintain.

@andre15silva
Copy link
Member

There's also another issue with parallelization. test-runner's entry point is configured statically, so we need to change that too.

@martinezmatias
Copy link
Collaborator Author

Hi @andre15silva

ok, I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants