Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the QuadraticIntegralFactor work? #17

Open
JzHuai0108 opened this issue Jan 23, 2024 · 0 comments
Open

Does the QuadraticIntegralFactor work? #17

JzHuai0108 opened this issue Jan 23, 2024 · 0 comments

Comments

@JzHuai0108
Copy link

JzHuai0108 commented Jan 23, 2024

Dear authors,

Thank you for opening source the great work, CLINS.
Browsing the code, I have a question about the QuadraticIntegralFactor.
First, its usage in the codebase has been commented out, so it seems the factor is not used at all.
Second, according to the comment, its implementation refers to the segmentQuadraticIntegralDiag in Kalibr. However, the kalibr uses a weight matrix Q of size Dim * SplineOrder, whereas CLINS uses a Q of size SplineOrder * SplineOrder. The kalibr implementation apparently follows the derivation in the Sec 4.6 of paper.
Third, to my understanding, the derivation in Kalibr for quadratic integral is for ordinary B-splines on the Euclidean space. That is, it is probably not suitable for cumulative B-splines on Lie groups, esp. SO3 B splines.

So does this QuadraticIntegralFactor in CLINS work in your experience or thinking?

Thanks for your consideration,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant