Reproducing ./echo functionality with ./echo-non-kens

[dormail]

Is there an option to reproduce ./echo functionality with the ./echo-non-kens and some options? My client and server are giving correct responds but the tests are failing, e.g. one output could be

./echo-non-kens s 127.0.0.1 9000 echo-test
Server received
hello
Submitted answers:
  127.0.0.1 -> echo-test

./echo-non-kens c 127.0.0.1 9000 hello
Submitted answers:
  127.0.0.1 -> hello

and KENS is telling me

Expected equality of these values:
  server_ans
    Which is: ""
  expected_server_ans
    Which is: "echo-test"

Maybe I also did not understand the submitAnswer method, since it's purpose is not really clear to me (I used read/write to send/receive the data).

[Pusnow]

In the server application, you should call submitAnswer with client's IP address and request's content not response's.
In the client application, you should call submitAnswer with server's IP address and response's content not request's.

It seems you did the opposite.

[Pusnow]

@dormail It's totally expected. It is not possible to "bind" unavailable IPs.

To test with real network, you should bind 127.0.0.1 or your machine's IP address. 0.0.0.0 (bind all available IPs) is also file.

[Pusnow]

@songminwoo1 Could you explain more?

[Jongjunp]

I also suffer from the same problem.
When I run my code with './echo-non-kens', it shows me the following result.
For client,
./echo-non-kens c 127.0.0.1 9000 hello
Submitted answers: 127.0.0.1 -> nice_to_meet_you
For server,
./echo-non-kens s 127.0.0.1 9000 nice_to_meet_you
Submitted answers: 127.0.0.1 -> hello

However, when I run my code with './echo', it returns the following result.
For client,
: Failure Expected equality of these values: client_ans Which is: "" expected_client_ans Which is: "echo-test"
For server,
: Failure Expected equality of these values: server_ans Which is: "" expected_server_ans Which is: "echo-test"

I can't guess what is wrong with my code from the message.

[idev2580]

I also suffering from same problem with @Jongjunp.
KENS doesn't get any answers from my program. (Without KENS, it works perfectly.)

I tested

int EchoAssignment::serverMain(const char *bind_ip, int port,
                               const char *server_hello) {
  submitAnswer("KENS", "NOT WORK AT ALL");
  return 0;
}

but ./echo returned following result.
: Failure Expected equality of these values: server_ans Which is: "" expected_server_ans Which is: "echo-test"
(even though actual answer my code submitted was "NOT WORK AT ALL")

[Pusnow]

@Jongjunp @Xxix2580 see below answer.

[Pusnow]

For all who have message like:

Failure Expected equality of these values: client_ans Which is: "" expected_client_ans Which is: "echo-test"

If the your client/server's answer is empty (""), you may submit answer with wrong IP address.

This is submitAnswer method.

KENSv3/app/echo/EchoAssignment.hpp

Lines 51 to 55 in 3098c76

	// ip: peer(client or server)'s IP address
	// answer: peer's request/response
	void submitAnswer(const char *ip, const char *answer) {
	___answers[ip] = answer;
	}

You must submit answer with peer's IP address.
In the server, you should submit answer with client's IP address.
In the client, you should submit answer with server's IP address.

To know peer's IP address, you should use getpeername(2).

[Jongjunp]

I think your socket is declared as
socket(AF_INET, SOCK_STREAM, 0)
In KENS, you should declare a socket as follows.
socket(AF_INET, SOCK_STREAM, IPPROTO_TCP)
See https://github.com/ANLAB-KAIST/KENSv3/discussions/29

[dormail]

@Jongjunp Yeah I have seen the discussion and changed the socket input parameter. Now the ./echo does not halt anymore, but the output still does not show any submitted answers.

[Pusnow]

@dormail okay, could you send your codes to us? [email protected]

[Pusnow]

@dormail I've checked your source codes and found you didn't initialize addrlen_cl (the third parameter of accept).

According to accept(2), you should initialize it to size of the address_cl (the second parameter).

The addrlen argument is a value-result argument: the caller must initialize it to contain the size (in bytes) of the structure pointed to by addr; on return it will contain the actual size of the peer address.

[dormail]

Yes, now it works, thank you very much for your efforts!