-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically create kernels for tutorial using jupyterlab-requirements-cli in a step in aicoe-pipeline #35
Comments
Related-To: thoth-station/jupyterlab-requirements#324 |
cc @MichaelClifford, so we can skip some steps of the tutorial, wdyt? |
I'm confused @pacospace if this should be done after the image is spawned, it can't be part of the build pipeline. Can you please clarify when you expect this step to happen? If it's part of the build phase, can this be included as a custom s2i assembly script? It seems fairly specific for this given use case/repository, isn't it? |
/area comet |
Yes build process sounds good, s2i assembly script seems to be the right place. In this way, if notebooks are missing dependencies, the build process will fail also as those are not reproducible. |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. /close |
@sesheta: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This could be done after image is spawned (checking dependencies from the notebooks) and install those kernels so they are ready for the users. Even though it will slow down a bit the spawning process
The text was updated successfully, but these errors were encountered: