Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace contract Solidity call Dual VM #82

Open
6 tasks
MSghais opened this issue Aug 28, 2024 · 11 comments
Open
6 tasks

Namespace contract Solidity call Dual VM #82

MSghais opened this issue Aug 28, 2024 · 11 comments
Labels
bug Something isn't working features Build new features fix Let's fix this and move forward good first issue Good for newcomers ODHack8 OD Hack 8 issues onchain Cairo & Solidity smart contracts solidity Solidity smart contract test Testing for developers and contributors/users

Comments

@MSghais
Copy link
Member

MSghais commented Aug 28, 2024

Description

Namespace contract Solidity call Dual VM.
We have an issue with felt252 conversion in Solidity to a uint256 calldata.
We need to fix this issue to finish the test for the claim deposit one:

Check namespace.cairo here:

describe("NamespaceDualVM", function () {

Tests are here:

describe("NamespaceDualVM", function () {

Namespace cairo dualvm:
Check out the Cairo contract here:
https://github.com/AFK-AlignedFamKernel/afk_monorepo/blob/main/onchain/cairo/src/social/namespace.cairo

Todo

  • Fix felt252 conversion issue
  • Check namespace.cairo functions to do in Solidity.
  • getNostrAddressByStarknetAddress
  • getStarknetAddressByNostrAddress
  • linked_nostr_default_account
  • Write Dual test in Hardhat: see example in DualVMToken.test.ts
@MSghais MSghais added good first issue Good for newcomers features Build new features onchain Cairo & Solidity smart contracts ODHack8 OD Hack 8 issues test Testing for developers and contributors/users solidity Solidity smart contract labels Aug 28, 2024
@ShantelPeters
Copy link

ShantelPeters commented Aug 28, 2024

Hi can i work on this ?

Copy link

onlydustapp bot commented Aug 28, 2024

Hi @ShantelPeters!
Maintainers during the ODHack # 7.0 will be tracking applications via OnlyDust.
Therefore, in order for you to have a chance at being assigned to this issue, please apply directly here, or else your application may not be considered.

@ScottyDavies
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hello, I am frontend developer and first time contributor

How I plan on tackling this issue

ETA 2-4 days

@mitarumi
Copy link

mitarumi commented Aug 28, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a developer with expertise in solidity and cairo

How I plan on tackling this issue

I'll create the functions and create test using hardhat. ETA 2-3 days

@ryzen-xp
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm a Solidity and Cairo developer specializing in NFT marketplaces and decentralized applications. With experience in ERC-721 ERC-20 and multi-token support, my work on projects like Worldcoin-Bridge-Linea equips me to tackle issues lik felt252 conversion efficiently.

How I plan on tackling this issue

To address the felt252 conversion issue in the Namespace contract:

  1. Review the conversion logic in the Solidity code related to felt252 and uint256 calldata.
  2. Check the namespace.cairo functions** to align with Solidity requirements.
  3. Fix the felt252 conversion in relevant Solidity functions.
  4. Write Hardhat tests for Dual VM interactions based on existing test examples.
    This will resolve the conversion issue and complete the claim deposit tests.

@saimeunt
Copy link
Contributor

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have experience both in Solidity and Cairo testing.

How I plan on tackling this issue

I will carefully read and understand the current test suite and implement all the necessary coverage needed as well as fix the problem regarding felt252/uint256 conversion.

@Jemiiah
Copy link

Jemiiah commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I would love to work on this issue worked on solidity repos like world coin Linea and scroll

How I plan on tackling this issue

I have experience in solidity code and ETA 48 hrs

@MSghais
Copy link
Member Author

MSghais commented Sep 26, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have experience both in Solidity and Cairo testing.

How I plan on tackling this issue

I will carefully read and understand the current test suite and implement all the necessary coverage needed as well as fix the problem regarding felt252/uint256 conversion.

Gm! Please, can you ping me on Telegram?

Copy link

onlydustapp bot commented Sep 26, 2024

The maintainer MSghais has assigned Jemiiah to this issue via OnlyDust Platform.
Good luck!

@MSghais MSghais added bug Something isn't working fix Let's fix this and move forward labels Sep 26, 2024
@suhas-sensei
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have prior experience working with Solidity and Cairo contracts, particularly in handling cross-chain communication and data conversion issues. The task at hand involves fixing a felt252 conversion issue when mapping it to a uint256 in Solidity calldata, which is necessary to complete the test for the claim deposit functionality. My background in smart contract development equips me to handle this challenge efficiently.

How I plan on tackling this issue

  1. Address the felt252 conversion issue in Solidity, ensuring proper data handling between Solidity and Cairo.
  2. Review and verify the relevant functions in namespace.cairo to ensure compatibility with Solidity, specifically the following:

getNostrAddressByStarknetAddress
getStarknetAddressByNostrAddress
linked_nostr_default_account

  1. Write and implement a Dual VM test using Hardhat, drawing from the DualVMToken.test.ts example for guidance.
  2. Conduct comprehensive testing to validate the integration of both Solidity and Cairo contracts and ensure the desired functionality is achieved.

@MSghais pls :)

@BenFaruna
Copy link

BenFaruna commented Oct 5, 2024

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

My name is Benjamin and I am a software and Blockchain developer woth experience using cairo and solidity. My experience with both languages will help me navigate the challenge relatively easy and find thr requited solution that fits tbr challenge.

How I plan on tackling this issue

These are the steps that I would take to solve the issue

  1. Research how felt252 conversion works and implement it so the tests can pass
  2. Implement the namespace functions getNostrAddressByStarknetAddress, getStarknetAddressByNostrAddress and linked_nostr_default_account
  3. Write dual tests and ensure all tests pass

Expected time to complete issue is 48hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working features Build new features fix Let's fix this and move forward good first issue Good for newcomers ODHack8 OD Hack 8 issues onchain Cairo & Solidity smart contracts solidity Solidity smart contract test Testing for developers and contributors/users
Projects
None yet
Development

No branches or pull requests

9 participants