From fc888da4e9f7ccaabfd315b91965651586f478d7 Mon Sep 17 00:00:00 2001 From: JPDarby Date: Mon, 7 Aug 2023 14:17:24 +0100 Subject: [PATCH 1/2] lowercase c bug --- src/bayesianlinear.jl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bayesianlinear.jl b/src/bayesianlinear.jl index c563c01..cbfa462 100644 --- a/src/bayesianlinear.jl +++ b/src/bayesianlinear.jl @@ -126,7 +126,7 @@ $$ \begin{aligned} \mathrm{\mathcal{L}} = &- \frac{1}{2} \sum_{i=1}^r \frac{[\mathbf{U}^T \mathbf{y}]_i^2}{\sigma_0^2 d_i^2 + \sigma_\epsilon^2} - - \frac{1}{2} \sum_{i=r+1}^N \frac{[\mathbf{U}^T \mathbf{y}]_i^2}{\sigma_\epsilon^2} + - \frac{1}{2} \sum_{i=r+1}^N \frac{[\mathbf{U}^T \mathbf{y}]_i^2}{\sigma_\epsilon^2} \\ &- \frac{1}{2} \ln \prod_{i=1}^r (\sigma_0^2 d_i^2 + \sigma_\epsilon^2) - \frac{N-r}{2} \ln (\sigma_\epsilon^2) @@ -486,7 +486,7 @@ function bayesian_linear_regression_svd(X::Matrix{<:AbstractFloat}, UT_Y[1:length(S)] .*= var_0 .* S ./ (var_0 .* S .* S .+ var_e) c = V * UT_Y[1:length(S)] - res = Dict{String, Any}("c" => c, + res = Dict{String, Any}("C" => c, "lml" => lml, "var_0" => var_0, "var_e" => var_e) From fb0f618be602d2100d5b3363c261706a93735f58 Mon Sep 17 00:00:00 2001 From: Chuck Witt Date: Fri, 18 Aug 2023 11:16:36 +0100 Subject: [PATCH 2/2] fix test. --- test/test_bayesianlinear.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_bayesianlinear.jl b/test/test_bayesianlinear.jl index 3a15a03..85972ef 100644 --- a/test/test_bayesianlinear.jl +++ b/test/test_bayesianlinear.jl @@ -11,7 +11,7 @@ Y = float.([1; 2; 1]) res = ACEfit.BayesianLinear.bayesian_linear_regression_svd(X, Y; committee_size = committee_size, ret_covar = true) -mean, committee, covar = (res["c"], res["committee"], res["covar"]) +mean, committee, covar = (res["C"], res["committee"], res["covar"]) # test mean mean_approx = sum(committee; dims = 2) / committee_size @test maximum(abs.(mean_approx - mean)) < 0.01