Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong arguments order in OSCMisc_matchStringPatter #1

Open
rbarreiros opened this issue Jan 24, 2021 · 0 comments
Open

Wrong arguments order in OSCMisc_matchStringPatter #1

rbarreiros opened this issue Jan 24, 2021 · 0 comments

Comments

@rbarreiros
Copy link

Hello,

I know this is a really old lib, but I'm actually modifying it and trying to make it work with ChibiOS and lwip, and I noticed that in OSCServer.c, in the functions OSCServer_handleParsedMessages and OSCServer_handleStoredMessages, the argument order is wrong, it's:

OSCMisc_matchStringPattern(server->handlers[i].address, OSCMessage_getAddress(entry->message))

And should be:

OSCMisc_matchStringPattern(OSCMessage_getAddress(entry->message), server->handlers[i].address)

Since in OSCMisc_matchStringPattern, the argument being tested for wildcards is the second, and the wildcards should be in the handlers right ?

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant