Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visibility logging does not handle animation change during view #40

Open
7yl4r opened this issue May 23, 2013 · 0 comments
Open

visibility logging does not handle animation change during view #40

7yl4r opened this issue May 23, 2013 · 0 comments

Comments

@7yl4r
Copy link
Owner

7yl4r commented May 23, 2013

The viewLogger (in avatarWallapaper) responds to onVisibilityChanged() and then prints the time viewed along with the current animation, it is assumed that the animation at end of view time is the animation which was present the whole time. An example of when this breaks: I turn on phone screen, animation is running, while I'm looking at it the animation changes to sleeping. Now when I turn off the screen, the logger records that I viewed 'sleeping' for the full duration of my use.

This is probably not a big deal, since animation changes occur infrequently and view times are short, so the chance of seeing a change is rare.

In order to fix this, the logging should be broken out into a function which can then be easily called from within the timed scene changer as well as onVisibilityChanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant